Christoph Hellwig wrote:
On Tue, Jun 19, 2007 at 05:15:56PM +0100, Paulo Marques wrote:
The only in-kernel user of "memmem" is scripts/kallsyms.c and it only
uses it to find tokens that are 2 bytes in size. It is trivial to
replace it with a simple function that finds 2-byte tokens.
This should help users from systems that don't have the memmem GNU
extension available.
Please add a comment describing why it's there so that it's not ripped
out again by the first janitor looking over the code.
I don't see why it would seem a good idea to replace a simple find_token
function that searches for 2 byte tokens with a call to memmem. So, I
think this is not something a janitor would do.
The call to memmem was actually a left-over from a previous algorithm
that used variable sized tokens. With fixed size, 2 byte tokens, having
a specialized function is probably more efficient anyway.
--
Paulo Marques - www.grupopie.com
"Nostalgia isn't what it used to be."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
