On Wed, Jul 11, 2018 at 10:36:07AM +0100, Mark Rutland wrote:
> In many cases, it would be useful to be able to use the full
> sanity-checked refcount helpers regardless of CONFIG_REFCOUNT_FULL, as
> this would help to avoid duplicate warnings where callers try to
> sanity-check refcount manipulation.
>
> This patch refactors things such that the full refcount helpers were
> always built, as refcount_${op}_checked(), such that they can be used
> regardless of CONFIG_REFCOUNT_FULL. This will allow code which *always*
> wants a checked refcount to opt-in, avoiding the need to duplicate the
> logic for warnings.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Mark Rutland <[email protected]>
> Acked-by: Kees Cook <[email protected]>
> Reviewed-by: David Sterba <[email protected]>
> Cc: Boqun Feng <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Will Deacon <[email protected]>
> ---
> include/linux/refcount.h | 27 +++++++++++++++++-------
> lib/refcount.c | 53
> +++++++++++++++++++++++-------------------------
> 2 files changed, 45 insertions(+), 35 deletions(-)
Looks good to me:
Acked-by: Will Deacon <[email protected]>
Will