On 07/15/2018 09:03 PM, Jiang Biao wrote: > -static p4d_t *pti_user_pagetable_walk_p4d(unsigned long address) > +static p4d_t *pti_user_pagetable_walk_p4d(const unsigned long address) > { > pgd_t *pgd = kernel_to_user_pgdp(pgd_offset_k(address)); > gfp_t gfp = (GFP_KERNEL | __GFP_NOTRACK | __GFP_ZERO);
I'm also a bit ambivalent on this one. While this is _correct_ and not something I think we actively discourage, it's not something that we're horribly diligent about doing universally in the kernel.