Re: [PATCH 27/32] staging: gasket: remove else clause after return in if clause

[Dan Carpenter]

On Mon, Jul 16, 2018 at 07:09:21PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoy...@google.com>
> 
> Else after return is unnecessary and may cause static code checkers to
> complain.
> 
> Reported-by: Guenter Roeck <gro...@chromium.org>
> Signed-off-by: Simon Que <s...@chromium.org>
> Signed-off-by: Todd Poynor <toddpoy...@google.com>
> ---
>  drivers/staging/gasket/gasket_page_table.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/gasket/gasket_page_table.c 
> b/drivers/staging/gasket/gasket_page_table.c
> index 2a27db658a4e4..080bf78c22c3b 100644
> --- a/drivers/staging/gasket/gasket_page_table.c
> +++ b/drivers/staging/gasket/gasket_page_table.c
> @@ -598,9 +598,8 @@ bool gasket_page_table_is_dev_addr_bad(
>       if (gasket_addr_is_simple(pg_tbl, dev_addr))
>               return gasket_is_simple_dev_addr_bad(
>                       pg_tbl, dev_addr, num_pages);
> -     else
> -             return gasket_is_extended_dev_addr_bad(
> -                     pg_tbl, dev_addr, num_pages);
> +     return gasket_is_extended_dev_addr_bad(
> +             pg_tbl, dev_addr, num_pages);

This isn't the normal way to break up a line.  It might even cause
problems if you run with checkpatch.pl --strict.  And anyway this fits
on one line:

        return gasket_is_extended_dev_addr_bad(pg_tbl, dev_addr, num_pages);

But normally we would do:

        return gasket_is_extended_dev_addr_bad(pg_tbl, dev_addr, num_pages,
                                               wha'ever, blah, blah, blah);

There are times when that looks a bit ugly if the variable names are
long so we could do:

        return gasket_is_extended_dev_addr_bad(
                                long_variable_name_asdfasdfaasdf,
                                pg_tbl, dev_addr);

But generally try to get a couple tabs in from the start of the function
name.

regards,
dan carpenter