On 2018-07-17 15:53, Tetsuo Handa wrote: > On 2018/07/17 18:01, Rasmus Villemoes wrote: >> Why not this instead? Less stack use, less code, no intermediary >> snprintfs, no pr_cont... > > Excellent! I didn't notice %ph extension. > >> Not compile-tested, probably whitespace-damaged, but you get the idea. > > Yes, it works well. > > > > From 96d9d4d135994a081e54d33d23f5007c53d9b5dd Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa <[email protected]> > Date: Tue, 17 Jul 2018 22:47:11 +0900 > Subject: [PATCH v3] x86: Avoid pr_cont() in show_opcodes() > > Since syzbot is confused by concurrent printk() messages [1], > this patch changes show_opcodes() to use %*ph format string. > > When we start adding prefix to each line of printk() output, > we will be able to handle concurrent printk() messages. > > [1] https://syzkaller.appspot.com/text?tag=CrashReport&x=139d342c400000 > > Signed-off-by: Tetsuo Handa <[email protected]> > Signed-off-by: Rasmus Villemoes <[email protected]>
I'm not sure that SoB-chain is correct. Anyway, however which way, and if at all, you want to credit me, please use the email address [email protected] . I probably botched From header in the previous mail, not used to using Thunderbird... Rasmus
