On Fri, Jul 13, 2018 at 02:55:46PM -0700, Joel Fernandes wrote: > + /* keep srcu and sched-rcu usage consistent */ \ > + preempt_disable_notrace(); \ > + \ > + /* \ > + * For rcuidle callers, use srcu since sched-rcu \ > + * doesn't work from the idle path. \ > + */ \ > + if (rcuidle) \ > + idx = srcu_read_lock_notrace(&tracepoint_srcu); \ > + else \ > + rcu_read_lock_sched_notrace(); \
That else is completely superfluous. rcu_read_lock_sched_notrace() := prempt_disable_notrace().
