On Tue, Jul 17, 2018 at 3:13 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> From: Todd Poynor <toddpoy...@google.com> >> >> Return right away instead of break out of while and then return. >> > > You could remove the (retries == max_retries) condition since that's > always true now and pull that code in one tab. You could do it in one > patch because they're closely related so it's One Thing [tm].
Ah yes, also removed the impossible-to-reach "return 0" at the end, thanks -- Todd > > regads, > dan carpenter
