Re: [PATCH v3 4/8] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

[Huang, Ying]

Christoph Hellwig <h...@infradead.org> writes:

>>  static inline bool cluster_is_huge(struct swap_cluster_info *info)
>>  {
>> -    return info->flags & CLUSTER_FLAG_HUGE;
>> +    if (IS_ENABLED(CONFIG_THP_SWAP))
>> +            return info->flags & CLUSTER_FLAG_HUGE;
>> +    else
>> +            return false;
>
> Nitpick: no need for an else after a return:
>
>       if (IS_ENABLED(CONFIG_THP_SWAP))
>               return info->flags & CLUSTER_FLAG_HUGE;
>       return false;

Sure.  Will change this in next version.

Best Regards,
Huang, Ying