Hi, On Fri, Jul 20, 2018 at 4:50 AM, Dilip Kota <dk...@codeaurora.org> wrote: > This patch series adds SPI driver support for GENI based QUP. > Also adding the device tree binding document for reference > as per reviewers request which was merged in Linus tree. > > Girish Mahadevan (1): > spi: spi-geni-qcom: Add SPI driver support for GENI based QUP > > drivers/spi/Kconfig | 12 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-geni-qcom.c | 685 > ++++++++++++++++++++++++++++++++++++++ > include/linux/spi/spi-geni-qcom.h | 14 + > 4 files changed, 712 insertions(+) > create mode 100644 drivers/spi/spi-geni-qcom.c > create mode 100644 include/linux/spi/spi-geni-qcom.h
This looks like it was supposed to be a cover letter. Typically that's labelled as "patch 0" in the series. Other handy traditions: * The cover letter should contain a description of what changed between this patch and the last one * You only want a cover letter for a patch series with more than one patch in it. In your case you only have one patch so you should have no cover letter. * It's handy if your cover letter has prefixes that match the subsystem just like the patch itself. AKA: "spi: spi-geni-qcom:" Personally I use "patman" to help me with sending out my patches. See <https://github.com/u-boot/u-boot/tree/master/tools/patman>. -Doug
