On 21/07/18 12:47 AM, Julia Lawall wrote: > From: kbuild test robot <[email protected]> > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Fixes: c75153197d20 ("NTB: Introduce NTB MSI Test Client") > Signed-off-by: kbuild test robot <[email protected]> > Signed-off-by: Julia Lawall <[email protected]> > --- > > I don't know much about this issue, beyondwhat is explained by the > semantic patch. Please check if the changes can be relevant. Oops, this work wasn't meant for public consumption yet. Everyone pretend you didn't see that ;). I must have pushed it to my repo that kbuild tests by accident. Though, I'm glad to have learned about the more efficient use of debugfs attributes. Logan
