Re: [PATCH] cpu/hotplug: Fix cpuhp_step name for timers

[Mukesh Ojha]

Hi All,

Please review V2 where i will be updating(minor) commit text.

Thanks.
Mukesh


On 7/24/2018 8:07 PM, Mukesh Ojha wrote:

After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
for timer looks to invalid. So, better to name it as
"timers:prepare".

Signed-off-by: Mukesh Ojha <mo...@codeaurora.org>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Lai Jiangshan <jiangshan...@gmail.com>
Cc: Ingo Molnar <mi...@kernel.org>
Cc: Brendan Jackman <brendan.jack...@arm.com>
Cc: Mathieu Malaterre <ma...@debian.org>
---
  kernel/cpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 0db8938..8e6606a 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)
         * otherwise a RCU stall occurs.
         */
        [CPUHP_TIMERS_PREPARE] = {
-               .name                   = "timers:dead",
+               .name                   = "timers:prepare",
                .startup.single         = timers_prepare_cpu,
                .teardown.single        = timers_dead_cpu,
        },