On Thursday, July 26, 2018 10:15:03 AM CEST Kai-Heng Feng wrote: > > > On 2018Jul26, at 16:14, Rafael J. Wysocki <raf...@kernel.org> wrote: > > > > On Thu, Jul 26, 2018 at 5:46 AM, Kai-Heng Feng > > <kai.heng.f...@canonical.com> wrote: > >> Hi Rafael, > >> > >>> On 2018Jul24, at 18:36, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > >>> > >>> On Tuesday, July 24, 2018 11:13:42 AM CEST Rafael J. Wysocki wrote: > >>>> On Tuesday, July 24, 2018 10:46:09 AM CEST Kai Heng Feng wrote: > >>>>> Hi Rafael, > >>>>> > >>>>>> On Jun 13, 2018, at 7:17 PM, Rafael J. Wysocki <r...@rjwysocki.net> > >>>>>> wrote: > >>>>>> > >>>>>> From: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > >>>>>> > >>>>>> It is reported that commit a192aa923b66a (ACPI / LPSS: Consolidate > >>>>>> runtime PM and system sleep handling) introduced a system suspend > >>>>>> regression on some machines, but the only functional change made by > >>>>>> it was to cause the PM quirks in the LPSS to also be used during > >>>>>> system suspend and resume. While that should always work for > >>>>>> suspend-to-idle, it turns out to be problematic for S3 > >>>>>> (suspend-to-RAM). > >>>>>> > >>>>>> To address that issue restore the previous S3 suspend and resume > >>>>>> behavior of the LPSS to avoid applying PM quirks then. > >>>>> > >>>>> The users reported that this patch does fix the S3 issue, but the S4 > >>>>> still > >>>>> fails. > >>>>> > >>>>> Please refer to [1] for more for user's testing result. > >>>>> > >>>>> [1] > >>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1774950/comments/60 > >>>> > >>>> Please ask the users to test the patch below, then, on top of the > >>>> $subject one. > >>> > >>> There was a mistake in the previous patch I posted, sorry about that. > >>> > >>> Please test this one instead: > >> > >> The result is positive, thanks! > > > > Good, thanks! > > > > I assume that S3 still works with this patch applied too. > > Yes, S3 continues to work with this patch.
OK, thanks! Let me resend the patch with a proper subject and changelog, then.
