> -----Original Message----- > From: Jassi Brar [mailto:[email protected]] > Sent: Thursday, July 26, 2018 7:37 PM > To: A.s. Dong <[email protected]> > Cc: Oleksij Rempel <[email protected]>; Shawn Guo > <[email protected]>; Fabio Estevam <[email protected]>; Rob > Herring <[email protected]>; Mark Rutland <[email protected]>; > Vladimir Zapolskiy <[email protected]>; Sudeep Holla > <[email protected]>; Devicetree List <[email protected]>; > Linux Kernel Mailing List <[email protected]>; , Sascha Hauer > <[email protected]>; , [email protected], linux- > [email protected], srv_heupstream <linux-arm- > [email protected]>; dl-linux-imx <[email protected]> > Subject: Re: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be > equal to 0 > > On Thu, Jul 26, 2018 at 4:30 PM, A.s. Dong <[email protected]> wrote: > >> -----Original Message----- > >> From: Jassi Brar [mailto:[email protected]] > >> Sent: Thursday, July 26, 2018 5:42 PM > >> To: Oleksij Rempel <[email protected]> > >> Cc: Shawn Guo <[email protected]>; Fabio Estevam > >> <[email protected]>; Rob Herring <[email protected]>; Mark > >> Rutland <[email protected]>; A.s. Dong <[email protected]>; > >> Vladimir Zapolskiy <[email protected]>; Sudeep Holla > >> <[email protected]>; Devicetree List <[email protected]>; > >> Linux Kernel Mailing List <[email protected]>; , Sascha > >> Hauer <[email protected]>; , > >> [email protected], linux- > >> [email protected], srv_heupstream <linux-arm- > >> [email protected]>; dl-linux-imx <[email protected]> > >> Subject: Re: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to > >> be equal to 0 > >> > >> On Thu, Jul 26, 2018 at 12:23 PM, Oleksij Rempel > >> <[email protected]> > >> wrote: > >> > From: Dong Aisheng <[email protected]> > >> > > >> > Mailbox devices may have only one channel which means the > >> > mbox-cells at least 1 does not make sense for this type devices. > >> > Let's remove that limitation to allow the mbox-cells to be equal to 0. > >> > > >> OK > >> > >> But please realise that you'll have to write more code -- implement > >> your own > >> of_xlate() callback. > >> Most developers would prefer to call the only channel as channel > >> number 0, and use the common of_xlate implementation. > >> > > > > Yes, that's true because the common of_xlate assuming the mbox-cells is 1. > > And there's already such users: > > arch/arm/boot/dts/bcm283x.dtsi > > > You mean that is a good thing, right?
No, I mean there's similar HW in kernel already that only has one channel. Are you suggesting even for one channel mailbox, we should still use Mbox-cells 1 and use 'mboxes = <&mailbox 0>' in devicetree? Regards Dong Aisheng
