usb_probe() is never called in atomic context.
It calls usb_alloc_coherent() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com>
---
 drivers/input/misc/yealink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/misc/yealink.c b/drivers/input/misc/yealink.c
index f0c9bf87b4e3..1365cd94ed9b 100644
--- a/drivers/input/misc/yealink.c
+++ b/drivers/input/misc/yealink.c
@@ -894,12 +894,12 @@ static int usb_probe(struct usb_interface *intf, const 
struct usb_device_id *id)
 
        /* allocate usb buffers */
        yld->irq_data = usb_alloc_coherent(udev, USB_PKT_LEN,
-                                          GFP_ATOMIC, &yld->irq_dma);
+                                          GFP_KERNEL, &yld->irq_dma);
        if (yld->irq_data == NULL)
                return usb_cleanup(yld, -ENOMEM);
 
        yld->ctl_data = usb_alloc_coherent(udev, USB_PKT_LEN,
-                                          GFP_ATOMIC, &yld->ctl_dma);
+                                          GFP_KERNEL, &yld->ctl_dma);
        if (!yld->ctl_data)
                return usb_cleanup(yld, -ENOMEM);
 
-- 
2.17.0

Reply via email to