Hello Andy, > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Andy > Shevchenko > Sent: Thursday, July 26, 2018 10:44 PM > To: Hayashibara, Keiji/林原 啓二 <[email protected]> > Cc: Mark Brown <[email protected]>; Rob Herring <[email protected]>; Mark > Rutland <[email protected]>; > Yamada, Masahiro/山田 真弘 <[email protected]>; linux-spi > <[email protected]>; linux-arm > Mailing List <[email protected]>; devicetree > <[email protected]>; Masami Hiramatsu > <[email protected]>; Jassi Brar <[email protected]>; Linux > Kernel Mailing List > <[email protected]>; Hayashi, Kunihiko/林 邦彦 > <[email protected]> > Subject: Re: [PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC > > On Thu, Jul 26, 2018 at 12:38 PM, Keiji Hayashibara > <[email protected]> wrote: > > >> > + /* check if requested speed is too small */ > >> > + if (ckrat > SSI_MAX_CLK_DIVIDER) > >> > >> > + return -EINVAL; > >> > >> So, does this critical? > > > > If set the value to SSI_MAX_CLK_DIVIDER, the clock frequency will be set > > high. > > I don't change it to high frequency, and it is daringly an error. > > On the other hand, when changing to low frequency, I will change it > > automatically. > > No. My point is, if somehow user asks for that condition to be happened you > bail out, while when using clamp_val() > you may continue to work at maximum limit, though issue warning to user, for > example.
Thank you. I understood what you pointed out. However, I found this code unnecessary as pointed out by Radu, so I will delete it. > >> > + > >> > + if (ckrat < SSI_MIN_CLK_DIVIDER) > >> > + ckrat = SSI_MIN_CLK_DIVIDER; > >> > >> clamp_val() / max() ? > > > > I will modify it to use max(). > > See above. This is also the same as above. > -- > With Best Regards, > Andy Shevchenko ----------------- Best Regards, Keiji Hayashibara
