On Tue, Jul 31, 2018 at 06:13:58PM +0200, Anna-Maria Gleixner wrote: > local_timer_softirq_pending() checks whether the timer softirq is > pending with: local_softirq_pending() & TIMER_SOFTIRQ. > > This is wrong because TIMER_SOFTIRQ is the softirq number and not a > bitmask. So the test checks for the wrong bit. > > Use BIT(TIMER_SOFTIRQ) instead. > > Fixes: 5d62c183f9e9 ("nohz: Prevent a timer interrupt storm in > tick_nohz_stop_sched_tick()") > Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de>
Acked-by: Frederic Weisbecker <frede...@kernel.org> Thanks!