Hi Richard, > -----Original Message----- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Wednesday, August 1, 2018 2:15 PM > To: Y.b. Lu <yangbo...@nxp.com> > Cc: net...@vger.kernel.org; Madalin-cristian Bucur > <madalin.bu...@nxp.com>; Rob Herring <robh...@kernel.org>; Shawn Guo > <shawn...@kernel.org>; David S . Miller <da...@davemloft.net>; > devicet...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for > initialization > > On Wed, Aug 01, 2018 at 04:36:40AM +0000, Y.b. Lu wrote: > > > Could I add a function to calculate a set of default register values > > to initialize ptp timer when dts method failed to get required > > properties in driver? > > Yes, it would be ideal if the driver can pick correct values automatically. > > However, the frequency on the FIPER outputs can't be configured > automatically, and we don't have an API for the user to choose this.
[Y.b. Lu] Thanks a lot. Just let me send out the v2 patch for your reviewing. > > > I think this will be useful. The ptp timer on new platforms (you may > > see two dts patches in this patchset. Many platforms will be > > affected.) will work without these dts properties. If user want > > specific setting, they can set dts properties. > > Sure. > > Thanks, > Richard
