On Thu, Aug 02, 2018 at 09:15:53PM +0200, Marcus Folkesson wrote:
> MCP3911 is a dual channel Analog Front End (AFE) containing two
> synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
>
> Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com>
> Signed-off-by: Kent Gustavsson <k...@minoris.se>
> ---
>
> Notes:
> v3:
> - add bindings for interrupt
> - prefix device-addr with `microchip`
> - drop `clock-names`
> v2:
> - drop channel width
> - drop `external_vref`
> - replace `external-clock` with proper clock bindings
>
> .../devicetree/bindings/iio/adc/mcp3911.txt | 32
> ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/mcp3911.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/mcp3911.txt
> b/Documentation/devicetree/bindings/iio/adc/mcp3911.txt
> new file mode 100644
> index 000000000000..432da7a28783
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/mcp3911.txt
> @@ -0,0 +1,32 @@
> +* Microchip MCP3911 Dual channel analog front end (ADC)
> +
> +Required properties:
> + - compatible: Should be "microchip,mcp3911"
> + - reg: SPI chip select number for the device
> +
> +Recommended properties:
> + - spi-max-frequency: Definition as per
> + Documentation/devicetree/bindings/spi/spi-bus.txt.
> + Max frequency for this chip is 20MHz.
> +
> +Optional properties:
> + - clocks: Phandle and clock identifier for sampling clock
> + - interrupt-parent: Phandle to the parent interrupt controller
> + see:
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
Drop this. It is implied.
With that,
Reviewed-by: Rob Herring <r...@kernel.org>
> + - interrupts: IRQ line for the ADC
> + see:
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> + - microchip,device-addr: Device address when multiple MCP3911 chips are
> present on the
> + same SPI bus. Valid values are 0-3. Defaults to 0.
> + - vref-supply: Phandle to the external reference voltage supply.
> +
> +Example:
> +adc@0 {
> + compatible = "microchip,mcp3911";
> + reg = <0>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <15 IRQ_TYPE_EDGE_RISING>;
> + spi-max-frequency = <20000000>;
> + microchip,device-addr = <0>;
> + vref-supply = <&vref_reg>;
> + clocks = <&xtal>;
> +};
> --
> 2.11.0.rc2
>
