On Thu, Aug 09, 2018 at 09:08:34AM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam <yazen.ghan...@amd.com> > > During mce_threshold_create_device() data structures are allocated for > each CPUs MCA banks and thresholding blocks. These data structures are > used to save information related to AMD's MCA Error Thresholding > feature. The structures are used in the thresholding interrupt handler, > and they are exposed to the user through sysfs. The sysfs interface has > user-friendly names for each bank. > > However, errors in mce_threshold_create_device() will cause all the data > structures to be deallocated. This will break the thresholding interrupt > handler since it depends on these structures.
Same argument as before: if our init fails in some fashion, we should not be running the interrupt handler. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --