On Thu, Aug 9, 2018 at 2:03 PM, Steven Rostedt <rost...@goodmis.org> wrote:
> From: "Steven Rostedt (VMware)" <rost...@goodmis.org>
>
> Joel Fernandes created a nice patch that cleaned up the duplicate hooks used
> by lockdep and irqsoff latency tracer. It made both use tracepoints. But it
> caused lockdep to trigger several false positives. We have not figured out
> why yet, but removing lockdep from using the trace event hooks and just call
> its helper functions directly (like it use to), makes the problem go away.
>
> This is a partial revert of the clean up patch c3bc8fd637a9 ("tracing:
> Centralize preemptirq tracepoints and unify their usage") that adds direct
> calls for lockdep, but also keeps most of the clean up done to get rid of
> the horrible preprocessor if statements.
>
> Link: http://lkml.kernel.org/r/20180806155058.5ee87...@gandalf.local.home
>
> Cc: Joel Fernandes <joe...@google.com>
> Cc: Peter Zijlstra <pet...@infradead.org>
> Fixes: c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints and unify
> their usage")
Reviewed-by: Joel Fernandes (Google) <j...@joelfernandes.org>
thanks,
- Joel
> Signed-off-by: Steven Rostedt (VMware) <rost...@goodmis.org>
> ---
> include/linux/irqflags.h | 8 ++++++--
> include/linux/lockdep.h | 2 --
> init/main.c | 2 --
> kernel/locking/lockdep.c | 14 ++-----------
> kernel/trace/trace_preemptirq.c | 36 ++++++++++++++++++---------------
> 5 files changed, 28 insertions(+), 34 deletions(-)
>
> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
