On 13.08.2018 17:46, osalva...@techadventures.net wrote: > From: Oscar Salvador <osalva...@suse.de> > > Before calling to unregister_mem_sect_under_nodes(), > remove_memory_section() already checks if we got a valid > memory_block. > > No need to check that again in unregister_mem_sect_under_nodes(). > > Signed-off-by: Oscar Salvador <osalva...@suse.de> > --- > drivers/base/node.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index 1ac4c36e13bb..dd3bdab230b2 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -455,10 +455,6 @@ int unregister_mem_sect_under_nodes(struct memory_block > *mem_blk, > NODEMASK_ALLOC(nodemask_t, unlinked_nodes, GFP_KERNEL); > unsigned long pfn, sect_start_pfn, sect_end_pfn; > > - if (!mem_blk) { > - NODEMASK_FREE(unlinked_nodes); > - return -EFAULT; > - } > if (!unlinked_nodes) > return -ENOMEM; > nodes_clear(*unlinked_nodes); >
While it is correct in current code, I wonder if this sanity check should stay. I would completely agree if it would be a static function. -- Thanks, David / dhildenb