Jiri Olsa <jo...@redhat.com> writes:
> On Tue, Aug 14, 2018 at 03:06:44PM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Tue, Aug 14, 2018 at 09:27:26AM +0200, Jiri Olsa escreveu:
>> > On Tue, Aug 14, 2018 at 11:47:39AM +1000, Michael Ellerman wrote:
>> > > Jiri Olsa <jo...@kernel.org> writes:
>> > > > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
>> > > > index ea48aa6f8d19..9d466e853aec 100755
>> > > > --- a/tools/perf/check-headers.sh
>> > > > +++ b/tools/perf/check-headers.sh
>> > > > @@ -88,6 +88,8 @@ check () {
>> > > > # differences.
>> > > > test -d ../../include || exit 0
>> > > >
>> > > > +pushd ../.. > /dev/null
>> > > > +
>> > > > # simple diff check
>> > > > for i in $HEADERS; do
>> > > > check $i -B
>> > >
>> > > This breaks the build when sh is not bash:
>> > >
>> > > ./check-headers.sh: 91: ./check-headers.sh: pushd: not found
>> > > ./check-headers.sh: 107: ./check-headers.sh: popd: not found
>> > > Makefile.perf:205: recipe for target 'sub-make' failed
>> >
>> > sry.. Arnaldo, would you change it for simple cd (attached below)
>> > or should I send the fix?
>>
>> Nah, I'm folding this in, to keep it bisectable.
>
> any chance one of your docker tests could run build in sh/zsh? ;-)
Just using an Ubuntu image, where /bin/sh == dash should work, that's
how I hit it.
cheers
