On 2018/8/16 7:23, Florian Fainelli wrote: > On 08/13/2018 04:24 AM, zhong jiang wrote: >> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So >> just replace them rather than duplicating its implement. > Subject should be: > > phy: phy-brcm-usb: Use PTR_ERR_OR_ZERO to replace open coded version Thank you for tips. It is my mistake.:-[
Sincerely, zhong jiang > Thank you > >> Signed-off-by: zhong jiang <zhongji...@huawei.com> >> --- >> drivers/phy/broadcom/phy-brcm-usb.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/phy/broadcom/phy-brcm-usb.c >> b/drivers/phy/broadcom/phy-brcm-usb.c >> index d1dab36..f59b1dc 100644 >> --- a/drivers/phy/broadcom/phy-brcm-usb.c >> +++ b/drivers/phy/broadcom/phy-brcm-usb.c >> @@ -372,10 +372,8 @@ static int brcm_usb_phy_probe(struct platform_device >> *pdev) >> clk_disable(priv->usb_30_clk); >> >> phy_provider = devm_of_phy_provider_register(dev, brcm_usb_phy_xlate); >> - if (IS_ERR(phy_provider)) >> - return PTR_ERR(phy_provider); >> >> - return 0; >> + return PTR_ERR_OR_ZERO(phy_provider); >> } >> >> #ifdef CONFIG_PM_SLEEP >> >
