On Wed, Aug 15, 2018 at 7:05 PM Joe Perches <j...@perches.com> wrote: > > Why does the commit change snd_hda_gen_add_micmute_led > to return 0; instead of return 1; > > That bit looks wrong.
Well, it changes the comment too, and is clearly intentional. I guess the logic was to have the usual "0 for success, negative for error" logic. Which is good - but dammit, when you change the return value, you should definitely check and update all the callers. Because yes, updating the call in alc_fixup_dell_wmi() fixes the problem for me. Grr. I wasted a fair amount of time on this. Linus