On Tue, 21 Aug 2018 09:22:07 +0000 Naga Sureshkumar Relli <nagas...@xilinx.com> wrote:
> Hi Boris, > > > -----Original Message----- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Tuesday, August 21, 2018 11:30 AM > > To: Naga Sureshkumar Relli <nagas...@xilinx.com> > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; > > kyungmin.p...@samsung.com; > > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > > linux- > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > <mich...@xilinx.com>; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device > > tree binding > > documentation > > > > On Tue, 21 Aug 2018 05:47:18 +0000 > > Naga Sureshkumar Relli <nagas...@xilinx.com> wrote: > > > > > > > +Required properties: > > > > > +- compatible: Should be "xlnx,zynqmp-nand" or > > > > > "arasan,nfc-v3p10" > > > > > > > > In your example it's not an "or" since both are defined. > > > In our previous discussion > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > We decided to have compatible strings like " compatible = > > > "<soc-vendor>,<ip-revision>", > > "arasan,<ip-revision>";" > > > So it should be either of these. > > > so I will write something like below > > > "Possible values are "xlnx,zynqmp-nand" > > > "arasan,nfc-v3p10" > > > And in example I will mention any one compatible. > > > Is it ok? > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > overloaded by a soc specific > > compat? > Actually we put these compatible strings based on the comments on v7 series. > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. If Rob said you should have both, then keep both, but the description should match, because "arasan,nfc-v3p10" cannot be used alone, it has to be placed next to a "<vendor>,nfc-<soc>" string.
