On Mon, 2018-08-27 at 06:59 +0000, Christophe Leroy wrote: > This warning was there to avoid the use of 0bxxx values > as they are not supported by gcc prior to v4.3 > > Since commit cafa0010cd51f ("Raise the minimum required gcc > version to 4.6"), it's not an issue anymore and using > such values can increase readability of code.
Seems sensible as the other compilers also support binary literals from relatively old versions. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3472.pdf https://software.intel.com/en-us/articles/c14-features-supported-by-intel-c-compiler > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> > --- > scripts/checkpatch.pl | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 5219280bf7ff..d98650790722 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -4933,17 +4933,6 @@ sub process { > while ($line =~ m{($Constant|$Lval)}g) { > my $var = $1; > > -#gcc binary extension > - if ($var =~ /^$Binary$/) { > - if (WARN("GCC_BINARY_CONSTANT", > - "Avoid gcc v4.3+ binary constant > extension: <$var>\n" . $herecurr) && > - $fix) { > - my $hexval = sprintf("0x%x", oct($var)); > - $fixed[$fixlinenr] =~ > - s/\b$var\b/$hexval/; > - } > - } > - > #CamelCase > if ($var !~ /^$Constant$/ && > $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&