On Mon, Aug 27, 2018 at 10:21:51AM +0200, Johan Hovold wrote:
> Use the new of_get_compatible_child() helper to lookup the mdio-internal
> child node instead of using of_find_compatible_node(), which searches
> the entire tree from a given start node and thus can return an unrelated
> (i.e. non-child) node.
>
> This also addresses a potential use-after-free (e.g. after probe
> deferral) as the tree-wide helper drops a reference to its first
> argument (i.e. the mdio-mux node). Fortunately, this was inadvertently
> balanced by a failure to drop the mdio-mux reference after lookup.
>
> While at it, also fix the related mdio-internal- and phy-node reference
> leaks.
>
> Fixes: 634db83b8265 ("net: stmmac: dwmac-sun8i: Handle integrated/external
> MDIOs")
> Cc: Corentin Labbe <[email protected]>
> Cc: Andrew Lunn <[email protected]>
> Cc: Giuseppe Cavallaro <[email protected]>
> Cc: Alexandre Torgue <[email protected]>
> Cc: Jose Abreu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>
You should have CCed sunxi maintainers
Maxime Ripard <[email protected]> (maintainer:ARM/Allwinner sunXi SoC
support)
Chen-Yu Tsai <[email protected]> (maintainer:ARM/Allwinner sunXi SoC support)
Since I am just back from holidays, I will test this patch this week.
Regards
