Hi Boris, 
 
> If we're going to do this, it needs to be tested on an x86 box which loads
> ghes_edac. Adding Toshi to Cc.
> 
> Otherwise it must remain ARM-specific.

Toshi it would be great if you can help! I'll also test the change in x86 but
not sure if the firmware updates module_handle.

> > +static int ghes_edac_dimm_index(u16 handle)
> 
> get_dimm_smbios_handle()

This function returns an index. So how about get_dimm_smbios_index()?

> > +{
> > +   struct mem_ctl_info *mci;
> > +   int i;
> > +
> > +   if (!ghes_pvt)
> > +           return -1;
> 
> You don't need that test.

Will remove.
 
> > +
> > +   mci = ghes_pvt->mci;
> > +
> > +   if (!mci)
> > +           return -1;
> 
> Ditto.

Will remove

Thanks,
Fan

Reply via email to