Hi David,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/David-Frey/regmap-split-regmap_config-use_single_rw/20180901-141401
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 
for-next
config: x86_64-randconfig-x018-201834 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the 
linux-review/David-Frey/regmap-split-regmap_config-use_single_rw/20180901-141401
 HEAD ccc00a1af2b149f8dd70fe9bd1a047361070be43 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers//mfd/da9052-spi.c: In function 'da9052_spi_probe':
>> drivers//mfd/da9052-spi.c:49:9: error: 'struct regmap_config' has no member 
>> named 'use_single_rw'; did you mean 'use_single_read'?
     config.use_single_rw = 1;
            ^~~~~~~~~~~~~
            use_single_read

vim +49 drivers//mfd/da9052-spi.c

cfe04478 Ashish Jangam            2011-12-12  23  
f791be49 Bill Pemberton           2012-11-19  24  static int 
da9052_spi_probe(struct spi_device *spi)
cfe04478 Ashish Jangam            2011-12-12  25  {
e9e9d397 Axel Lin                 2014-08-16  26        struct regmap_config 
config;
cfe04478 Ashish Jangam            2011-12-12  27        int ret;
cfe04478 Ashish Jangam            2011-12-12  28        const struct 
spi_device_id *id = spi_get_device_id(spi);
6608a5e2 Axel Lin                 2012-05-11  29        struct da9052 *da9052;
cfe04478 Ashish Jangam            2011-12-12  30  
6608a5e2 Axel Lin                 2012-05-11  31        da9052 = 
devm_kzalloc(&spi->dev, sizeof(struct da9052), GFP_KERNEL);
cfe04478 Ashish Jangam            2011-12-12  32        if (!da9052)
cfe04478 Ashish Jangam            2011-12-12  33                return -ENOMEM;
cfe04478 Ashish Jangam            2011-12-12  34  
72e341c4 Adam Ward                2015-03-04  35        spi->mode = SPI_MODE_0;
cfe04478 Ashish Jangam            2011-12-12  36        spi->bits_per_word = 8;
cfe04478 Ashish Jangam            2011-12-12  37        spi_setup(spi);
cfe04478 Ashish Jangam            2011-12-12  38  
cfe04478 Ashish Jangam            2011-12-12  39        da9052->dev = &spi->dev;
cfe04478 Ashish Jangam            2011-12-12  40        da9052->chip_irq = 
spi->irq;
cfe04478 Ashish Jangam            2011-12-12  41  
1b1ba09c Jingoo Han               2013-04-06  42        spi_set_drvdata(spi, 
da9052);
cfe04478 Ashish Jangam            2011-12-12  43  
e9e9d397 Axel Lin                 2014-08-16  44        config = 
da9052_regmap_config;
e9e9d397 Axel Lin                 2014-08-16  45        config.read_flag_mask = 
1;
72e341c4 Adam Ward                2015-03-04  46        config.reg_bits = 7;
72e341c4 Adam Ward                2015-03-04  47        config.pad_bits = 1;
72e341c4 Adam Ward                2015-03-04  48        config.val_bits = 8;
72e341c4 Adam Ward                2015-03-04 @49        config.use_single_rw = 
1;
cfe04478 Ashish Jangam            2011-12-12  50  
e9e9d397 Axel Lin                 2014-08-16  51        da9052->regmap = 
devm_regmap_init_spi(spi, &config);
cfe04478 Ashish Jangam            2011-12-12  52        if 
(IS_ERR(da9052->regmap)) {
cfe04478 Ashish Jangam            2011-12-12  53                ret = 
PTR_ERR(da9052->regmap);
cfe04478 Ashish Jangam            2011-12-12  54                
dev_err(&spi->dev, "Failed to allocate register map: %d\n",
cfe04478 Ashish Jangam            2011-12-12  55                        ret);
6608a5e2 Axel Lin                 2012-05-11  56                return ret;
cfe04478 Ashish Jangam            2011-12-12  57        }
cfe04478 Ashish Jangam            2011-12-12  58  
ad698ea4 Javier Martinez Canillas 2015-09-29  59        return 
da9052_device_init(da9052, id->driver_data);
cfe04478 Ashish Jangam            2011-12-12  60  }
cfe04478 Ashish Jangam            2011-12-12  61  

:::::: The code at line 49 was first introduced by commit
:::::: 72e341c48fbca142d767e97746e33a4becf890ea mfd: da9052: Fix register 
access via SPI

:::::: TO: Adam Ward <[email protected]>
:::::: CC: Lee Jones <[email protected]>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to