> On Mon, Sep 03, 2018 at 05:03:56AM +0000, Prakhya, Sai Praneeth wrote: > > Hmm.. thought that __efi_init might be confusing with the normal > > __init attribute > > How would that be confusing? It has "__efi" prepended?! > > All I'm saying is, if you're going to define your own function attributes, do > them > generic and short. "_fixup" is too specific IMO. It also enlarges function > definitions unnecessarily. >
Yes.. agreed that the function definitions did enlarge. > With "__efi_init" you already denote that it is a special attribute which has > relevance in the EFI code only. What you do about it - the > *fixup* - is the thing you do with the attribute. But you don't have to have > the > "what you do" in the attribute name too. Ok.. makes sense. Will roll a V3 with __efi_init. Regards, Sai
