On 9/6/2018 2:24 PM, Heiko Carstens wrote:
On Thu, Sep 06, 2018 at 02:16:27PM +0800, Ding Xiang wrote:device_unregister will put device, do not need to do it one more time Signed-off-by: Ding Xiang <dingxi...@cmss.chinamobile.com> --- drivers/s390/scsi/zfcp_unit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/scsi/zfcp_unit.c b/drivers/s390/scsi/zfcp_unit.c index 1bf0a09..6b50084 100644 --- a/drivers/s390/scsi/zfcp_unit.c +++ b/drivers/s390/scsi/zfcp_unit.c @@ -249,8 +249,6 @@ int zfcp_unit_remove(struct zfcp_port *port, u64 fcp_lun) scsi_device_put(sdev); } - put_device(&unit->dev); - device_unregister(&unit->dev); return 0;I'm quite sure this change is wrong, since the put_device() here seems to pair with the get_device() in _zfcp_unit_find(). So we would end up with a memory leak.
Indeed，please ignore this patch.
Adding Steffen and Benjamin.
