On 09/09/18 02:18, Olof Johansson wrote:
> Hi,
>
> On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah <jolly.s...@xilinx.com> wrote:
>> From: Rajan Vaja <raj...@xilinx.com>
>>
>> Add ZynqMP firmware IOCTL API to control and configure
>> devices like PLLs, SD, Gem, etc.
>>
>> Signed-off-by: Rajan Vaja <raj...@xilinx.com>
>> Signed-off-by: Jolly Shah <jol...@xilinx.com>
>
> This patch worries me somewhat. It's a transparent pass-through ioctl
> driver. Is there a spec available for what the implemented IOCTLs are?
>
> Should some of them be proper drivers instead of an opaque
> pass-through like this? Could some of them have stability impact on
> the platform such that there are security concerns and the list of
> arguments should somehow be sanitized?
>
> What's the intended usecase anyway? Just a debug tool during
> development, or something that you expect heavy use of by some
> userspace middleware?
>
Thanks for pointing this out. My earlier attempts were ignored[1]
and I gave up.
--
Regards,
Sudeep
[1] https://lkml.org/lkml/2018/5/10/298
