On 2018/9/11 18:14, Borislav Petkov wrote:
@@ -1211,9 +1216,11 @@ void __init sync_Arb_IDs(void) { /* * Unsupported on P4 - see Intel Dev. Manual Vol. 3, Ch. 8.6.1 And not - * needed on AMD. + * needed on AMD or Hygon. */ - if (modern_apic() || boot_cpu_data.x86_vendor == X86_VENDOR_AMD) + if (modern_apic() || + boot_cpu_data.x86_vendor == X86_VENDOR_AMD || + boot_cpu_data.x86_vendor == X86_VENDOR_HYGON)This change is not needed, after the above hunk in modern_apic(), right?
Yes, you are right. Since the Hygon Dhyana CPU always uses modern APIC, so the function modern_apic will always return true for Hygon Dhyana. I will remove this change in next version of patch.
With it removed: Reviewed-by: Borislav Petkov <[email protected]>
-- Regards, Pu Wen
