> On Thu, Sep 13, 2018 at 10:32:39PM +0200, Robert Węcławski wrote: > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c > > b/drivers/staging/rtl8188eu/core/rtw_mlme.c > > index eca06f05c0c4..b610443f2ac6 100644 > > --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c > > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c > > @@ -1819,16 +1819,6 @@ void rtw_update_registrypriv_dev_network(struct > > adapter *adapter) > > case WIRELESS_11BG_24N: > > pdev_network->NetworkTypeInUse = Ndis802_11OFDM24; > > break; > > - case WIRELESS_11A: > > - case WIRELESS_11A_5N: > > - pdev_network->NetworkTypeInUse = Ndis802_11OFDM5; > > - break; > > - case WIRELESS_11ABGN: > > - if (pregistrypriv->channel > 14) > > - pdev_network->NetworkTypeInUse = Ndis802_11OFDM5; > > - else > > - pdev_network->NetworkTypeInUse = Ndis802_11OFDM24; > > - break; > > default: > > /* TODO */ > > break; > > Are you sure about this chunk? I would have thought that <= 14 was not > 5G. (I try to avoid rhetorical questions and I don't know the answer > here). > > regards, > dan carpenter
I'm 99% sure this part is not needed because this chipset only supports B, G and N WiFi networks. I think we should add pdev_network->NetworkTypeInUse = Ndis802_110FDM5 to default case to be 100% sure it won't break anything. If we do this we can be sure pdev_network->NetworkTypeInUse will be set. Should I make a new version of this patch?
