[PATCH 11/21] platform: goldfish: pipe: Move memory allocation from probe to init

[rkir]

From: Roman Kiryanov <r...@google.com>

There will be two separate init functions for v1 and v2 and they
will allocate different state.

Signed-off-by: Roman Kiryanov <r...@google.com>
---
 drivers/platform/goldfish/goldfish_pipe_v2.c | 41 +++++++++++---------
 1 file changed, 22 insertions(+), 19 deletions(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe_v2.c 
b/drivers/platform/goldfish/goldfish_pipe_v2.c
index c68035be4389..ccde28abcb24 100644
--- a/drivers/platform/goldfish/goldfish_pipe_v2.c
+++ b/drivers/platform/goldfish/goldfish_pipe_v2.c
@@ -241,8 +241,6 @@ struct goldfish_pipe_dev {
        struct device *pdev_dev;
 
        /* Some device-specific data */
-       int irq;
-       int version;
        unsigned char __iomem *base;
 
        /* an irq tasklet to run goldfish_interrupt_task */
@@ -1125,14 +1123,23 @@ static void write_pa_addr(void *addr, void __iomem 
*portl, void __iomem *porth)
 }
 
 static int goldfish_pipe_device_init(struct platform_device *pdev,
-                                    struct goldfish_pipe_dev *dev)
+                                    char __iomem *base,
+                                    int irq)
 {
+       struct goldfish_pipe_dev *dev;
        int err;
 
+       dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
+       if (!dev)
+               return -ENOMEM;
+
+       dev->magic = &goldfish_pipe_device_deinit;
+       spin_lock_init(&dev->lock);
+
        tasklet_init(&dev->irq_tasklet, &goldfish_interrupt_task,
                     (unsigned long)dev);
 
-       err = devm_request_irq(&pdev->dev, dev->irq,
+       err = devm_request_irq(&pdev->dev, irq,
                               goldfish_pipe_interrupt,
                               IRQF_SHARED, "goldfish_pipe", dev);
        if (err) {
@@ -1147,6 +1154,7 @@ static int goldfish_pipe_device_init(struct 
platform_device *pdev,
                return err;
        }
 
+       dev->base = base;
        dev->pdev_dev = &pdev->dev;
        dev->first_signalled_pipe = NULL;
        dev->pipes_capacity = INITIAL_PIPES_CAPACITY;
@@ -1197,22 +1205,17 @@ static void goldfish_pipe_device_deinit(struct 
platform_device *pdev,
 static int goldfish_pipe_probe(struct platform_device *pdev)
 {
        struct resource *r;
-       struct goldfish_pipe_dev *dev;
-
-       dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-       if (!dev)
-               return -ENOMEM;
-
-       dev->magic = &goldfish_pipe_device_deinit;
-       spin_lock_init(&dev->lock);
+       char __iomem *base;
+       int irq;
+       int version;
 
        r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (!r || resource_size(r) < PAGE_SIZE) {
                dev_err(&pdev->dev, "can't allocate i/o page\n");
                return -EINVAL;
        }
-       dev->base = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE);
-       if (!dev->base) {
+       base = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE);
+       if (!base) {
                dev_err(&pdev->dev, "ioremap failed\n");
                return -EINVAL;
        }
@@ -1221,7 +1224,7 @@ static int goldfish_pipe_probe(struct platform_device 
*pdev)
        if (!r)
                return -EINVAL;
 
-       dev->irq = r->start;
+       irq = r->start;
 
        /*
         * Exchange the versions with the host device
@@ -1230,12 +1233,12 @@ static int goldfish_pipe_probe(struct platform_device 
*pdev)
         *  reading device version back: this allows the host implementation to
         *  detect the old driver (if there was no version write before read).
         */
-       writel((u32)PIPE_DRIVER_VERSION, dev->base + PIPE_REG_VERSION);
-       dev->version = readl(dev->base + PIPE_REG_VERSION);
-       if (WARN_ON(dev->version < PIPE_CURRENT_DEVICE_VERSION))
+       writel((u32)PIPE_DRIVER_VERSION, base + PIPE_REG_VERSION);
+       version = readl(base + PIPE_REG_VERSION);
+       if (WARN_ON(version < PIPE_CURRENT_DEVICE_VERSION))
                return -EINVAL;
 
-       return goldfish_pipe_device_init(pdev, dev);
+       return goldfish_pipe_device_init(pdev, base, irq);
 }
 
 static int goldfish_pipe_remove(struct platform_device *pdev)
-- 
2.19.0.397.gdd90340f6a-goog