From: Nadav Amit <na...@vmware.com>

[ Upstream commit 7279d9917560bbd0d82813d6bf00490a82c06783 ]

men_z127_debounce() tries to round up and down, but uses functions which
are only suitable when the divider is a power of two, which is not the
case. Use the appropriate ones.

Found by static check. Compile tested.

Fixes: f436bc2726c64 ("gpio: add driver for MEN 16Z127 GPIO controller")
Signed-off-by: Nadav Amit <na...@vmware.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
---
 drivers/gpio/gpio-menz127.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
index a1210e330571..95061d25895b 100644
--- a/drivers/gpio/gpio-menz127.c
+++ b/drivers/gpio/gpio-menz127.c
@@ -56,9 +56,9 @@ static int men_z127_debounce(struct gpio_chip *gc, unsigned 
gpio,
                rnd = fls(debounce) - 1;
 
                if (rnd && (debounce & BIT(rnd - 1)))
-                       debounce = round_up(debounce, MEN_Z127_DB_MIN_US);
+                       debounce = roundup(debounce, MEN_Z127_DB_MIN_US);
                else
-                       debounce = round_down(debounce, MEN_Z127_DB_MIN_US);
+                       debounce = rounddown(debounce, MEN_Z127_DB_MIN_US);
 
                if (debounce > MEN_Z127_DB_MAX_US)
                        debounce = MEN_Z127_DB_MAX_US;
-- 
2.17.1

Reply via email to