Hi Rob, Thanks for providing the comments... Please find my response inline.
> -----Original Message----- > From: Rob Herring [mailto:[email protected]] > Sent: Tuesday, September 11, 2018 1:42 AM > To: Nava kishore Manne <[email protected]> > Cc: [email protected]; Michal Simek <[email protected]>; > [email protected]; Rajan Vaja <[email protected]>; Jolly Shah > <[email protected]>; [email protected]; linux-arm- > [email protected]; [email protected] > Subject: Re: [RFC PATCH v3 2/3] dt-bindings: reset: Add bindings for ZynqMP > reset driver > > On Wed, Sep 05, 2018 at 12:39:01PM +0530, Nava kishore Manne wrote: > > Add documentation to describe Xilinx ZynqMP reset driver bindings. > > > > Signed-off-by: Nava kishore Manne <[email protected]> > > --- > > Changes for v3: > > -Corrected Commit Msg. > > Changes for v2: > > -Moved reset node as a child to firwmare > > node. > > Why? There's no reason for that. The parent can be multiple providers. > You only need child nodes if the sub functions have their own DT resources. > This driver having a dependency on firmware. So I have moved this node as a child to firmware As per other drivers which is using this firmware interface https://lkml.org/lkml/2018/8/14/432 I didn't get your comment could you please elaborate more??? Did you mean I should move the changes in the file to Documentation/devicetree/bindings/reset/ ??? Regards, Navakishore.
