On Sat, 2018-09-22 at 15:25 +1000, Dave Chinner wrote: > On Sat, Sep 22, 2018 at 01:15:42AM +0100, Ben Hutchings wrote: > > 3.16.58-rc1 review patch. If anyone has any objections, please let > > me know. > > > > ------------------ > > > > From: Dave Chinner <dchin...@redhat.com> > > > > commit ee457001ed6c6f31ddad69c24c1da8f377d8472d upstream. > > > > We recently came across a V4 filesystem causing memory corruption > > due to a newly allocated inode being setup twice and being added to > > the superblock inode list twice. From code inspection, the only way > > this could happen is if a newly allocated inode was not marked as > > free on disk (i.e. di_mode wasn't zero). > > .... > > Signed-Off-By: Dave Chinner <dchin...@redhat.com> > > Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> > > Tested-by: Carlos Maiolino <cmaiol...@redhat.com> > > Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > > Signed-off-by: Darrick J. Wong <darrick.w...@oracle.com> > > [bwh: Backported to 3.16: > > - Look up mode in XFS inode, not VFS inode > > - Use positive error codes, and EIO instead of EFSCORRUPTED] > > Why EIO?
I believe EIO was the usual error code used for filesystem errors before EFSCORRUPTED was added. But now I see xfs had its own private definition of EFSCORRUPTED. I'll change this back. Ben. -- Ben Hutchings Any sufficiently advanced bug is indistinguishable from a feature.
signature.asc
Description: This is a digitally signed message part
