Hi Boris, Thanks for the review.
> -----Original Message----- > From: Borislav Petkov [mailto:[email protected]] > Sent: Friday, September 21, 2018 2:46 PM > To: Manish Narani <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > Michal Simek <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected] > Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for > ddrc controller > > There's more: > > I said: > > > > @@ -370,12 +398,12 @@ static int synps_edac_init_csrows(struct > > > mem_ctl_info *mci) > > > That function returns 0 unconditionally. Make it a void in a prepatch. > > But you've lumped this change together with a bunch more. Maybe my request > wasn't clear so let me rephrase it: > > That function returns 0 unconditionally. Make it a void in a *separate* > prepatch. > > Ok? Yes, okay. 😊 I will keep it in a separate prepatch in v8. Thanks, Manish
