4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Julia Lawall <julia.law...@lip6.fr>

[ Upstream commit faa1a47388b33623e4d504c23569188907b039a0 ]

Return an error code on failure.  Change leading spaces to tab on the
first if.

Problem found using Coccinelle.

Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/parport/parport_sunbpp.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

--- a/drivers/parport/parport_sunbpp.c
+++ b/drivers/parport/parport_sunbpp.c
@@ -286,12 +286,16 @@ static int bpp_probe(struct platform_dev
 
        ops = kmemdup(&parport_sunbpp_ops, sizeof(struct parport_operations),
                      GFP_KERNEL);
-        if (!ops)
+       if (!ops) {
+               err = -ENOMEM;
                goto out_unmap;
+       }
 
        dprintk(("register_port\n"));
-       if (!(p = parport_register_port((unsigned long)base, irq, dma, ops)))
+       if (!(p = parport_register_port((unsigned long)base, irq, dma, ops))) {
+               err = -ENOMEM;
                goto out_free_ops;
+       }
 
        p->size = size;
        p->dev = &op->dev;


Reply via email to