On Tue, Jul 03, 2007 at 09:09:50AM -0400, David Woodhouse wrote: > On Tue, 2007-07-03 at 11:48 +0200, Rodolfo Giometti wrote: > > On Sun, Jul 01, 2007 at 01:03:11PM +0100, David Woodhouse wrote: > > > > > > Seems reasonable enough in principle -- but whatever you do, don't use > > > "long" for it. That would definitely need different behaviour for 32-bit > > > vs. 64-bit. Use explicitly sized types such as uint32_t or uint64_t. > > > > Here the patch to convert LinuxPPS data structs into fixed ones. > > > > Please, take a look at it and report possible modifications. > > Looks relatively sane at first glance; busy this week so haven't looked > very hard yet. Two thing though... you're mixing proper C types > (uint32_t) and the Linux-specific legacy crap types (__u32). Pick one. I > won't recommend _which_ one, because if I do I'll make Andrew unhappy. > But pick one; don't use both at the same time. > > Also read Documentation/volatile-considered-harmful.txt and ponder > deeply your use of 'volatile' on certain members of struct pps_s.
I will! Thanks a lot. Rodolfo -- GNU/Linux Solutions e-mail: [EMAIL PROTECTED] Linux Device Driver [EMAIL PROTECTED] Embedded Systems [EMAIL PROTECTED] UNIX programming phone: +39 349 2432127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
