Hi David,
The problem is that sun4c Sparc32 can't handle un-aligned variables so
having a 64bit readzone word that is not aligned on a 64bit boundary is a
problem.
In addition, having looked at the size calculations, it looks to me as if
not all of them got updated to handle 64bit redzone words. This may be part of
the problem. By making BYTES_PER_WORD 64bit aligned (Sparc32) this is
nolonger an issue.
Regards
Mark Fortescue.
On Tue, 3 Jul 2007, David Woodhouse wrote:
On Tue, 2007-07-03 at 19:57 +0100, Mark Fortescue wrote:
Commit b46b8f19c9cd435ecac4d9d12b39d78c137ecd66 partially fixed alignment
issues but does not ensure that all 64bit alignment requirements of sparc32
are met. Tests have shown that the redzone2 word can become misallignd.
Oops, sorry about that. I'm not sure about your patch though -- I think
I'd prefer to keep the redzone misaligned (and hence _right_ next to the
real data), and just deal with it.
typedef unsigned long long __aligned__((BYTES_PER_WORD)) redzone_t;
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
