Em Tue, Oct 02, 2018 at 10:29:12AM -0400, Sanskriti Sharma escreveu: > parse_ftrace_printk() tokenizes and parses a line, calling strdup() each > iteration. Add code to free this temporary format string duplicate. > > Fixes the following coverity complaints: > > Error: RESOURCE_LEAK (CWE-772): > tools/perf/util/trace-event-parse.c:158: overwrite_var: Overwriting > "printk" in "printk = strdup(fmt + 1)" leaks the storage that "printk" > points to. > > tools/perf/util/trace-event-parse.c:162: leaked_storage: Variable > "printk" going out of scope leaks the storage it points to.
Thanks, applied. - Arnaldo > Signed-off-by: Sanskriti Sharma <sansh...@redhat.com> > --- > tools/perf/util/trace-event-parse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/trace-event-parse.c > b/tools/perf/util/trace-event-parse.c > index e76214f..b15a9bf 100644 > --- a/tools/perf/util/trace-event-parse.c > +++ b/tools/perf/util/trace-event-parse.c > @@ -158,6 +158,7 @@ void parse_ftrace_printk(struct tep_handle *pevent, > printk = strdup(fmt+1); > line = strtok_r(NULL, "\n", &next); > tep_register_print_string(pevent, printk, addr); > + free(printk); > } > } > > -- > 1.8.3.1
