Hi Enric, On 03/10/2018 13:01, Enric Balletbo i Serra wrote: > Hi Emil, > > Many thanks to catch this and fix. Some comments below. > > You missed to add the v2, please send the next patch with v3 prefix. > > On 28/9/18 19:08, Emil Karlson wrote: >> Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard >> events >> be truncated on many chromebooks so that Left and Right keys on Column 12 >> were >> always 0. Use ret as memcpy len to fix this. >>
[...] > > Neil, can you give us your Tested-by to have the make sure this doesn't break > with protocol v1, I don't have such hardware. I'd like to, but I'm unable to get developer mode and legacy boot back on my TEEMO device... Neil > > Benson, will be really good have this merged in this rc. Are you fine with > this > solution? > > BTW, you can add my in next version. > > Acked-by: Enric Balletbo i Serra <enric.balle...@collabora.com> >