On Thu, Oct 04, 2018 at 10:12:44AM +0200, Daniel Lezcano wrote: > > Hi Peter, > > On 04/10/2018 09:57, Peter Zijlstra wrote: > > On Thu, Oct 04, 2018 at 09:42:07AM +0200, Daniel Lezcano wrote: > >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c > >> index b88a145..5605f03 100644 > >> --- a/kernel/sched/core.c > >> +++ b/kernel/sched/core.c > >> @@ -2873,25 +2873,12 @@ unsigned long long nr_context_switches(void) > >> > >> return sum; > >> } > >> -/* > >> - * Consumers of these two interfaces, like for example the cpufreq menu > >> - * governor are using nonsensical data. Boosting frequency for a CPU that > >> has > >> - * IO-wait which might not even end up running the task when it does > >> become > >> - * runnable. > >> - */ > >> > >> unsigned long nr_iowait_cpu(int cpu) > > > > +static > > The function is exported in include/linux/sched/stat.h and used by > drivers/cpuidle/governors/menu.c > > Do you want to declare it static inline in the stat.h file ?
No, but if there's a user left, that comment needs to stay. The number it returns is utter crap.
