Hi Boris, > -----Original Message----- > From: Yogesh Narayan Gaur > Sent: Thursday, October 4, 2018 2:56 PM > To: 'Boris Brezillon' <boris.brezil...@bootlin.com> > Cc: linux-...@lists.infradead.org; marek.va...@gmail.com; vigne...@ti.com; > linux-...@vger.kernel.org; devicet...@vger.kernel.org; r...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; linux-arm- > ker...@lists.infradead.org; computersforpe...@gmail.com; > frieder.schre...@exceet.de; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 1/4] spi: add support for octal I/O data transfer > > Hi Boris, > > > -----Original Message----- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Thursday, October 4, 2018 2:50 PM > > To: Yogesh Narayan Gaur <yogeshnarayan.g...@nxp.com> > > Cc: linux-...@lists.infradead.org; marek.va...@gmail.com; > > vigne...@ti.com; linux-...@vger.kernel.org; > > devicet...@vger.kernel.org; r...@kernel.org; mark.rutl...@arm.com; > > shawn...@kernel.org; linux-arm- ker...@lists.infradead.org; > > computersforpe...@gmail.com; frieder.schre...@exceet.de; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH 1/4] spi: add support for octal I/O data transfer > > > > On Thu, 4 Oct 2018 09:14:36 +0000 > > Yogesh Narayan Gaur <yogeshnarayan.g...@nxp.com> wrote: > > > > > Hi Boris, > > > > > > > -----Original Message----- > > > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > > > Sent: Thursday, October 4, 2018 2:35 PM > > > > To: Yogesh Narayan Gaur <yogeshnarayan.g...@nxp.com> > > > > Cc: linux-...@lists.infradead.org; marek.va...@gmail.com; > > > > vigne...@ti.com; linux-...@vger.kernel.org; > > > > devicet...@vger.kernel.org; r...@kernel.org; mark.rutl...@arm.com; > > > > shawn...@kernel.org; linux-arm- ker...@lists.infradead.org; > > > > computersforpe...@gmail.com; frieder.schre...@exceet.de; > > > > linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] spi: add > > > > support for octal I/O data transfer > > > > > > > > Hi Yogesh, > > > > [...] > > > > > +#define SPI_RX_OCTAL > > > > > 0x2000 /* receive with 8 wires > > > > */ > > > > > int irq; > > > > > void *controller_state; > > > > > void *controller_data; > > > > > > > > You're still not updating spi-mem.c to check those flags and > > > > SPI_MEM_MAX_BUSWIDTH is not updated to match the new limit (8 > > > > instead of 4). > > > > > > > Yes and its strange that my octal mode communication is working fine > > > without adding support in spi-mem.c and that's why this has been > > > missed from me. > > > > Are you based on top of spi-next? > > Ok, that might be the reason. I have rebased few days back. > Would rebase with current tip and add support in spi-mem interface too.
I have rebased spi-next and currently on top but still my octal command support is working fine without any issue with current shared patch series, performed data sanity. => git log --pretty=oneline -3 496c415717b8bb7d37181127fcfad0ba450eb10d mtd: spi-nor: fsl-quadspi: Don't let -EINVAL on the bus 2336d3a7b125683c9e8b25d6efa6064310d19dbe mtd: devices: m25p80: Make sure WRITE_EN is issued before each write e55841874471282d32eec595997afce43a5f55c0 mtd: spi-nor: Support controllers with limited TX FIFO size GIT Repo - git://git.infradead.org/linux-mtd.git Branch - remotes/origin/spi-nor/next Also, I am not able to find string SPI_MEM_MAX_BUSWIDTH in current source code, can you share the GIT details where these changes are pushed. -- Regards Yogesh Gaur.