On Wed, Oct 10, 2018 at 01:41:32PM +0200, Paul Kocialkowski wrote: > This adds support for the 3.5" LCD panel from Lemaker, sold for use with > BananaPi boards. It comes with a 24-bit RGB888 parallel interface and > requires an active-low DE signal > > Signed-off-by: Paul Kocialkowski <[email protected]> > --- > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c > index 97964f7f2ace..229080fcf65e 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1461,6 +1461,30 @@ static const struct panel_desc kyo_tcg121xglp = { > .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > }; > > +static const struct drm_display_mode lemaker_bl035_mode = { > + .clock = 7000, > + .hdisplay = 320, > + .hsync_start = 320 + 20, > + .hsync_end = 320 + 20 + 30, > + .htotal = 320 + 20 + 30 + 38, > + .vdisplay = 240, > + .vsync_start = 240 + 4, > + .vsync_end = 240 + 4 + 3, > + .vtotal = 240 + 4 + 3 + 15, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc lemaker_bl035 = { > + .modes = &lemaker_bl035_mode, > + .num_modes = 1, > + .size = { > + .width = 70, > + .height = 52, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_LOW, > +}; > + > static const struct drm_display_mode lg_lb070wv8_mode = { > .clock = 33246, > .hdisplay = 800, > @@ -2456,6 +2480,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "kyo,tcg121xglp", > .data = &kyo_tcg121xglp, > + }, { > + .compatible = "lemaker,bl035", > + .data = &lemaker_bl035,
You should document that new compatible. Also, where is this name coming from? Is it the name it's sold under? something you came up with? Thanks, Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
