On 16/10/18 14:36, Quentin Perret wrote:
> Hi,
>
> On Tuesday 16 Oct 2018 at 14:50:58 (+0200), Juri Lelli wrote:
> > Hi,
> >
> > On 16/10/18 11:15, Quentin Perret wrote:
> >
> > [...]
> >
> > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > > index cc02050fd0c4..481309a11174 100644
> > > --- a/kernel/sysctl.c
> > > +++ b/kernel/sysctl.c
> > > @@ -466,6 +466,17 @@ static struct ctl_table kern_table[] = {
> > > .extra1 = &one,
> > > },
> > > #endif
> > > +#if defined(CONFIG_ENERGY_MODEL) &&
> > > defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
> > > + {
> > > + .procname = "sched_energy_aware",
> > > + .data = &sysctl_sched_energy_aware,
> > > + .maxlen = sizeof(unsigned int),
> > > + .mode = 0644,
> > > + .proc_handler = sched_energy_aware_handler,
> > > + .extra1 = &zero,
> > > + .extra2 = &one,
> > > + },
> > > +#endif
> >
> > Doesn't this need to be documented in Documentation/sysctl/kernel.txt?
>
> Right, that'd be a good practice indeed. What do you think about the
> patch below ?
LGTM.
> > Also, do we want a kernel parameter as well to be able to disable this
> > at boot?
>
> Yeah, why not. But I guess we could always add that later if need be ?
Sure. Works with me.
Thanks,
- Juri
