4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Jérôme Glisse <jgli...@redhat.com>

commit bfba8e5cf28f413aa05571af493871d74438979f upstream.

Inside set_pmd_migration_entry() we are holding page table locks and thus
we can not sleep so we can not call invalidate_range_start/end()

So remove call to mmu_notifier_invalidate_range_start/end() because they
are call inside the function calling set_pmd_migration_entry() (see
try_to_unmap_one()).

Link: http://lkml.kernel.org/r/20181012181056.7864-1-jgli...@redhat.com
Signed-off-by: Jérôme Glisse <jgli...@redhat.com>
Reported-by: Andrea Arcangeli <aarca...@redhat.com>
Reviewed-by: Zi Yan <zi....@cs.rutgers.edu>
Acked-by: Michal Hocko <mho...@kernel.org>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
Cc: "H. Peter Anvin" <h...@zytor.com>
Cc: Anshuman Khandual <khand...@linux.vnet.ibm.com>
Cc: Dave Hansen <dave.han...@intel.com>
Cc: David Nellans <dnell...@nvidia.com>
Cc: Ingo Molnar <mi...@elte.hu>
Cc: Mel Gorman <mgor...@techsingularity.net>
Cc: Minchan Kim <minc...@kernel.org>
Cc: Naoya Horiguchi <n-horigu...@ah.jp.nec.com>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: Vlastimil Babka <vba...@suse.cz>
Cc: <sta...@vger.kernel.org>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 mm/huge_memory.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2843,9 +2843,6 @@ void set_pmd_migration_entry(struct page
        if (!(pvmw->pmd && !pvmw->pte))
                return;
 
-       mmu_notifier_invalidate_range_start(mm, address,
-                       address + HPAGE_PMD_SIZE);
-
        flush_cache_range(vma, address, address + HPAGE_PMD_SIZE);
        pmdval = *pvmw->pmd;
        pmdp_invalidate(vma, address, pvmw->pmd);
@@ -2858,9 +2855,6 @@ void set_pmd_migration_entry(struct page
        set_pmd_at(mm, address, pvmw->pmd, pmdswp);
        page_remove_rmap(page, true);
        put_page(page);
-
-       mmu_notifier_invalidate_range_end(mm, address,
-                       address + HPAGE_PMD_SIZE);
 }
 
 void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)


Reply via email to