On Wed, Oct 17, 2018 at 08:56:44AM +0200, Jan Kiszka wrote: > On 17.10.18 04:36, Du Changbin wrote: > > For gdb version less than 7.3, lx-version only one character. > > ^^^ prints? > I will update it, thanks!
> > (gdb) lx-version > > L(gdb) > > > > This can be fixed by casting 'linux_banner' as (char *). > > (gdb) lx-version > > Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu > > 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018 > > > > gdb 7.4 seems to be no such issue. > > > > Signed-off-by: Du Changbin <changbin...@gmail.com> > > --- > > scripts/gdb/linux/proc.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py > > index 086d27223c0c..0aebd7565b03 100644 > > --- a/scripts/gdb/linux/proc.py > > +++ b/scripts/gdb/linux/proc.py > > @@ -41,7 +41,7 @@ class LxVersion(gdb.Command): > > def invoke(self, arg, from_tty): > > # linux_banner should contain a newline > > - gdb.write(gdb.parse_and_eval("linux_banner").string()) > > + gdb.write(gdb.parse_and_eval("(char *)linux_banner").string()) > > LxVersion() > > > > Looks good to me otherwise. > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux -- Thanks, Du Changbin